This repository was archived by the owner on Aug 19, 2019. It is now read-only.
Add instrumentation and expose measurement in prometheus format#210
Open
StevenYCChou wants to merge 36 commits intoStackdriver:masterfrom
Open
Add instrumentation and expose measurement in prometheus format#210StevenYCChou wants to merge 36 commits intoStackdriver:masterfrom
StevenYCChou wants to merge 36 commits intoStackdriver:masterfrom
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add interface inside api_server, so we expose instrumentation metrics later on (currently working on it).
Some thoughts:
MetadataApiServer::SerializeMetricsToPrometheusTextFormat()so we can test the functionality without considering http_connection, which isn't tested in current test suites.